docs: make the demo tape portable - #16
Merged
Merged
Conversation
The recording tape hardcoded an absolute home path, which is both unreproducible on anyone else's machine and a personal detail to publish. Uses $HOME for the cargo bin path, and BULLPEN_HOME rather than overriding HOME to isolate the demo store — which is what BULLPEN_HOME exists for and did not when this tape was written. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PfAfAujueuZ3rDTiL9apx3
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe demo shell command now resolves Cargo from ChangesBullpen demo setup
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
🤖 Lab Code Review (draft opinion)No diff provided to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recording tape hardcoded
/Users/vics/..., which is unreproducible on anyone else's machine and a personal detail to publish. Caught while auditing the repo ahead of making it public.Now uses
$HOMEfor the cargo bin path, andBULLPEN_HOMEto isolate the demo store rather than overridingHOME— which is whatBULLPEN_HOMEis for, and didn't exist when this tape was written.No effect on the committed GIF; this only matters when re-recording with
vhs docs/media/bullpen-agents.tape.Summary by CodeRabbit